Skip to content
This repository was archived by the owner on Apr 11, 2025. It is now read-only.

Component schemas, missing endpoint and various fixes for Broker API spec#36

Open
manul7 wants to merge 12 commits intoalpacahq:masterfrom
manul7:master
Open

Component schemas, missing endpoint and various fixes for Broker API spec#36
manul7 wants to merge 12 commits intoalpacahq:masterfrom
manul7:master

Conversation

@manul7
Copy link
Copy Markdown

@manul7 manul7 commented Aug 23, 2022

Added new components schemas declaration for:

  • OathClientStatus
  • AssetStatus
  • BankAccountType
  • AchStatus
  • BankCodeType

Added missing endpoint for /v1/trading/accounts/{account_id}/orders:by_client_order_id

Added missing items for multiple enums and Contact component and fixed incorrect numbers declaration.

QA

  • Linter passes without issues and new warnings.
  • Validation passes without issues:
$ npm run validate broker/openapi.yaml 

> alpaca-oas@0.0.1 validate
> swagger-cli validate

broker/openapi.yaml is valid

@manul7
Copy link
Copy Markdown
Author

manul7 commented Aug 24, 2022

@drew887 could you please take a look?

@drew887
Copy link
Copy Markdown
Contributor

drew887 commented Aug 24, 2022

@manul7 Sorry I no longer work for Alpaca, @haxdds or @gsmadi are the main points of contact now I believe

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@manul7 @drew887